Increase initialisation speed by optionally excluding files to scan #697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves an issue with slow loading eel applications by offering the developer the option to exclude file paths from the EXPOSED_JS_FUNCTIONS scan.
Instead of just scanning all .html, .js and .txt files, the developer can exclude file paths containing any of the strings passed trough the exclude_path parameter.
In a typical html template, there are lots of javascript files that add GUI functionalities, and in one case this added up to 120 seconds when using the current init command.
eel.init('web') took 122.60855889320374 seconds
assuming all external javascript files are in the web/plugins directory, changing to the new option:
eel.init('web', exclude_path=['web/plugins']) took 1.013951301574707 seconds